Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strconv/quote: refactor - moved quotes to constants #34803

Closed
wants to merge 2 commits into from
Closed

strconv/quote: refactor - moved quotes to constants #34803

wants to merge 2 commits into from

Conversation

proggga
Copy link
Contributor

@proggga proggga commented Oct 9, 2019

in strconv/quote.go moved to constants ''" and '"'
small refactoring

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Oct 9, 2019
@proggga
Copy link
Contributor Author

proggga commented Oct 9, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Oct 9, 2019
@gopherbot
Copy link

This PR (HEAD: a80b167) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/200177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/200177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Robert Griesemer:

Patch Set 1:

(1 comment)

I'm not a fan of this. Leaving for somebody else. bradfitz@? rsc@?


Please don’t reply on this GitHub thread. Visit golang.org/cl/200177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1: Code-Review-1

I'd rather we didn't do this.


Please don’t reply on this GitHub thread. Visit golang.org/cl/200177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Robert Griesemer:

Patch Set 1: Code-Review-1

Patch Set 1: Code-Review-1

I'd rather we didn't do this.

Agreed. We don't want people to write strconv.DoubleQuote in their code when they can just write '"'. These quotes are defined by the language spec and won't change.


Please don’t reply on this GitHub thread. Visit golang.org/cl/200177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Mikhail Fesenko:

Patch Set 1:

Patch Set 1: Code-Review-1

Patch Set 1: Code-Review-1

I'd rather we didn't do this.

Agreed. We don't want people to write strconv.DoubleQuote in their code when they can just write '"'. These quotes are defined by the language spec and won't change.

Hi, yea I agree, but what if change it to private const? Ive made public by mistake.


Please don’t reply on this GitHub thread. Visit golang.org/cl/200177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 30c0797) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/200177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 367c9c3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/200177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: a3c0622) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/200177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@bradfitz bradfitz closed this Oct 10, 2019
@proggga proggga deleted the proggga/simple_refactor branch October 23, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants