New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strconv/quote: refactor - moved quotes to constants #34803
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: a80b167) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/200177 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/200177. |
Message from Robert Griesemer: Patch Set 1: (1 comment) I'm not a fan of this. Leaving for somebody else. bradfitz@? rsc@? Please don’t reply on this GitHub thread. Visit golang.org/cl/200177. |
Message from Brad Fitzpatrick: Patch Set 1: Code-Review-1 I'd rather we didn't do this. Please don’t reply on this GitHub thread. Visit golang.org/cl/200177. |
Message from Robert Griesemer: Patch Set 1: Code-Review-1
Agreed. We don't want people to write strconv.DoubleQuote in their code when they can just write '"'. These quotes are defined by the language spec and won't change. Please don’t reply on this GitHub thread. Visit golang.org/cl/200177. |
Message from Mikhail Fesenko: Patch Set 1:
Hi, yea I agree, but what if change it to private const? Ive made public by mistake. Please don’t reply on this GitHub thread. Visit golang.org/cl/200177. |
This PR (HEAD: 30c0797) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/200177 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 367c9c3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/200177 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: a3c0622) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/200177 to see it. Tip: You can toggle comments from me using the |
in strconv/quote.go moved to constants ''" and '"'
small refactoring