Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: newlines inconsistently preserved in go.mod rewriting [1.13 backport] #34800

Closed
gopherbot opened this issue Oct 9, 2019 · 6 comments
Closed

cmd/go: newlines inconsistently preserved in go.mod rewriting [1.13 backport] #34800

gopherbot opened this issue Oct 9, 2019 · 6 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@zx2c4 requested issue #33779 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport this to 1.13, because it's a regression from the 1. 12, and it causes dirty files in version control and disturbs other automated systems that don't appreciate stable file contents flopping around.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 9, 2019
@gopherbot gopherbot mentioned this issue Oct 9, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.2 milestone Oct 9, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/200118 mentions this issue: cmd/go/internal/modfile: remove preceding empty lines when setting require

@gopherbot
Copy link
Author

Change https://golang.org/cl/200118 mentions this issue: [release-branch.go1.13] cmd/go/internal/modfile: remove preceding empty lines when setting require

@av86743
Copy link

av86743 commented Oct 10, 2019

Isn't it in fact ...: removeall blanklines from require section?

@bcmills
Copy link
Contributor

bcmills commented Oct 10, 2019

I don't think we should backport this. It may be a regression, but it's cosmetic at best — and as far as I can tell has a simple workaround (namely, don't add newlines in a require block).

CC @jayconrod

@zx2c4
Copy link
Contributor

zx2c4 commented Oct 10, 2019

@bcmills That's fine with me. Feel free to close this (if jay doesn't disagree).

@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@toothrot
Copy link
Contributor

Closing this issue, as it doesn't seem to meet our bar of "serious problems with no workaround". Please comment if I am mistaken.

@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
6 participants
@toothrot @zx2c4 @av86743 @bcmills @gopherbot @katiehockman