Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modconv: TestConvertLegacyConfig failing on release-branch.go1.12 #34789

Closed
bcmills opened this issue Oct 9, 2019 · 2 comments
Closed

cmd/go/internal/modconv: TestConvertLegacyConfig failing on release-branch.go1.12 #34789

bcmills opened this issue Oct 9, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.12

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 9, 2019

From the llinux-amd64-longtest builder (https://build.golang.org/log/1120ec46cd7453ca78c1c763d3366a3a6788a2a9):

--- FAIL: TestConvertLegacyConfig (12.67s)
    --- FAIL: TestConvertLegacyConfig/github.com_fishy_gcsbucket_v0.0.0-20150410205453-618d60fe84e0 (1.79s)
        convert_test.go:161: unexpected status (http://10.240.0.72:30157/github.com/fishy/gcsbucket/@v/v0.0.0-20150410205453-618d60fe84e0.zip): 410 Gone
FAIL
FAIL	cmd/go/internal/modconv	12.736s

I believe this is #30571. To address it, we could see if the patch in https://golang.org/cl/167084 applies cleanly to the branch.

CC @toothrot @dmitshur @jayconrod
@bcmills bcmills added this to the Go1.12.11 milestone Oct 9, 2019
@bcmills bcmills added the CherryPickCandidate Used during the release process for point releases label Oct 9, 2019
@gopherbot
Copy link

Change https://golang.org/cl/200037 mentions this issue: [release-branch.go1.12] cmd/go/internal/{modconv,modfetch,modload}: set modfetch proxy URL in tests

@bcmills bcmills self-assigned this Oct 9, 2019
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Oct 9, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 9, 2019
@gopherbot
Copy link

Closed by merging df367ca to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Oct 9, 2019
@toothrot
[release-branch.go1.12] cmd/go/internal/{modconv,modfetch,modload}: s…
df367ca 
…et modfetch proxy URL in tests

Updates #30571
Fixes #34789

Change-Id: Id4c74e83ee58a080d1c2894ae5ebdbf4aeb1ce42
Reviewed-on: https://go-review.googlesource.com/c/go/+/167084
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit bd680d9)
Reviewed-on: https://go-review.googlesource.com/c/go/+/200037
@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.12
Development

No branches or pull requests
4 participants
@toothrot @bcmills @gopherbot @katiehockman