Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: ssh to linux-ppc64 buildlets uses wrong username #34739

Closed
jeremyfaller opened this issue Oct 7, 2019 · 9 comments
Closed

x/build/cmd/gomote: ssh to linux-ppc64 buildlets uses wrong username #34739

jeremyfaller opened this issue Oct 7, 2019 · 9 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@jeremyfaller
Copy link
Contributor

Created a linux-pp64-buildlet gomote, pushed my ROOT, and tried to build. Build failed with:

go install _/tmp/workdir-host-linux-ppc64-osu/go/src/cmd/dist: open cmd/dist/dist: permission denied

Investigating, the owner of WORDIR/go was root, not debian which is who gomote ssh apparently logs you in as.
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 7, 2019
@katiehockman katiehockman added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 10, 2019
@katiehockman
Copy link
Contributor

/cc @bradfitz

@bradfitz bradfitz changed the title x/build/cmd/gomote: gomote push set owner of WORKDIR to root x/build/cmd/gomote: ssh to linux-ppc64 buildlets uses wrong username Oct 10, 2019
@bradfitz
Copy link
Contributor

An easy fix is to adjust the SSHUsername field from "debian" to "root", but the bigger problem is these machines are ancient (Debian jessie) and don't use Docker to give users a fresh environment per build, so giving "root" to everybody means they can mess up machines.

I'll do the quick fix for now, but we should update these to from jessie to buster (via stretch) and use x/build/cmd/rundockerbuildlet on them.

/cc @toothrot

@gopherbot
Copy link

Change https://golang.org/cl/200377 mentions this issue: dashboard: fix ssh username for ppc64 builders

gopherbot pushed a commit to golang/build that referenced this issue Oct 10, 2019
@bradfitz
dashboard: fix ssh username for ppc64 builders
4c6d3ea 
Updates golang/go#34739

Change-Id: I9e9bcf66a4e3939a68178b344672a1bab2698bb4
Reviewed-on: https://go-review.googlesource.com/c/build/+/200377
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bradfitz
Copy link
Contributor

Deployed.

@bradfitz
Copy link
Contributor

And verified it works.

I'll close this for now and open a new bug about rundockerbuildlet.

@ceseo
Copy link
Contributor

ceseo commented Oct 10, 2019

@bradfitz do I need to change the username for the POWER9 builder too?

@bradfitz
Copy link
Contributor

Looks like it. The buildlet on the power9 one is running as root.

@ceseo
Copy link
Contributor

ceseo commented Oct 10, 2019

OK, I'll submit a CL.

@gopherbot
Copy link

Change https://golang.org/cl/200398 mentions this issue: dashboard: fix ssh username for ppc64le-power9 builder

gopherbot pushed a commit to golang/build that referenced this issue Oct 10, 2019
@ceseo @bradfitz
dashboard: fix ssh username for ppc64le-power9 builder
a07c53d 
Updates golang/go#34739

Change-Id: I6499ff6a0e1885fad3a5f5ba7c1fa4e0113e716c
Reviewed-on: https://go-review.googlesource.com/c/build/+/200398
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@bradfitz @codebien
dashboard: fix ssh username for ppc64 builders
f7f1aa9 
Updates golang/go#34739

Change-Id: I9e9bcf66a4e3939a68178b344672a1bab2698bb4
Reviewed-on: https://go-review.googlesource.com/c/build/+/200377
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@ceseo @codebien
dashboard: fix ssh username for ppc64le-power9 builder
28df231 
Updates golang/go#34739

Change-Id: I6499ff6a0e1885fad3a5f5ba7c1fa4e0113e716c
Reviewed-on: https://go-review.googlesource.com/c/build/+/200398
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @jeremyfaller @ceseo @gopherbot @katiehockman