Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime, internal/poll: darwin: ensure that no thread is consumed, nor a syscall.Read if FD isn't yet ready for I/O [1.13 backport] #34714

Closed
gopherbot opened this issue Oct 6, 2019 · 1 comment
Closed

runtime, internal/poll: darwin: ensure that no thread is consumed, nor a syscall.Read if FD isn't yet ready for I/O [1.13 backport] #34714

gopherbot opened this issue Oct 6, 2019 · 1 comment
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@odeke-em requested issue #33953 to be considered for backport to the next 1.13 minor release.

Some great news, @minux's CL https://go-review.googlesource.com/c/go/+/197938 fixed this issue in that change from entersyscallblock() to entersyscall() so we'll need to backport Minux's CL to both Go1.12 and Go1.13 as per https://groups.google.com/d/msg/golang-dev/UYDTDWHJsC8/a1_4KiKnCwAJ.

@gopherbot please backport this issue to Go1.12 and Go1.13.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 6, 2019
@gopherbot gopherbot mentioned this issue Oct 6, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.2 milestone Oct 6, 2019
@toothrot
Copy link
Contributor

toothrot commented Oct 9, 2019

This appears to be the same CL as #34712. Closing this issue in favor of that one.

@toothrot toothrot closed this as completed Oct 9, 2019
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@rsc rsc mentioned this issue Nov 21, 2019
Open
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
3 participants
@toothrot @gopherbot @katiehockman