Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go.mod parser accepts bogus versions #34697

Closed
jayconrod opened this issue Oct 4, 2019 · 1 comment
Closed

cmd/go: go.mod parser accepts bogus versions #34697

jayconrod opened this issue Oct 4, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@jayconrod
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.13.1 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/go/installed"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build714146284=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Write the go.mod file below:

module m

go bad1.13version

Run any command that reads go.mod, for example, go list -m all.

What did you expect to see?

Parse error in go.mod.

What did you see instead?

No error.

We check the version string using regexp.MatchString with the regular expression ([1-9][0-9]*)\.(0|[1-9][0-9]*). MatchString just checks the version string contains a string matching that expression. It can contain junk before and after.
@jayconrod jayconrod added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 4, 2019
@jayconrod jayconrod added this to the Go1.14 milestone Oct 4, 2019
@jayconrod jayconrod self-assigned this Oct 4, 2019
@gopherbot
Copy link

Change https://golang.org/cl/199017 mentions this issue: cmd/go/internal/modfile: report error for extra text around version

@golang golang locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot