Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: loading dependencies with go test -i does not correctly handle *.go import paths [1.13 backport] #34694

Closed
gopherbot opened this issue Oct 4, 2019 · 4 comments
Closed

cmd/go: loading dependencies with go test -i does not correctly handle *.go import paths [1.13 backport] #34694

gopherbot opened this issue Oct 4, 2019 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@Helcaraxan requested issue #34653 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport to 1.13, this was a regression
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 4, 2019
@gopherbot gopherbot mentioned this issue Oct 4, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.2 milestone Oct 4, 2019
@Helcaraxan
Copy link
Contributor

As per @bcmills's comment here I'd suggest that we backport the fix for this issue, which is overlapping with already backported fix for #32483.

@bcmills
Copy link
Contributor

bcmills commented Oct 4, 2019 •
edited

This would be a companion to #34243, for which the backport has already been merged.

@gopherbot
Copy link
Author

Change https://golang.org/cl/198957 mentions this issue: [release-branch.go1.13] cmd/go: fix listing of ambiguous paths

@andybons andybons added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 4, 2019
@gopherbot
Copy link
Author

Closed by merging 2f73eed to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Oct 7, 2019
@Helcaraxan
[release-branch.go1.13] cmd/go: fix listing of ambiguous paths
2f73eed 
Passing ambiguous patterns, ending in `.go`, to `go list` results in them
being interpreted as Go files despite potentially being package references.
This can then result in errors on other package references.

The parsing logic is modified to check for a locally present file
corresponding to any pattern ending in `.go`. If no such file is present
the pattern is considered to be a package reference.

We're also adding a variety of non-regression tests that fail with the
original parsing code but passes after applying the fix.

Updates #34653
Fixes #34694

Change-Id: I073871da0dfc5641a359643f95ac14608fdca09b
GitHub-Last-Rev: 5abc200
GitHub-Pull-Request: #34663
Reviewed-on: https://go-review.googlesource.com/c/go/+/198459
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 33683f1d64df0cef2c598a84b741abb5af8abe5e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/198957
Reviewed-by: Jay Conrod <jayconrod@google.com>
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
5 participants
@andybons @Helcaraxan @bcmills @gopherbot @katiehockman