Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/gcexportdata: 'undefined: gcimporter.IExportData' #34689

Closed
Aazhar opened this issue Oct 4, 2019 · 7 comments
Closed

x/tools/go/gcexportdata: 'undefined: gcimporter.IExportData' #34689

Aazhar opened this issue Oct 4, 2019 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@Aazhar
Copy link

Aazhar commented Oct 4, 2019

What version of Go are you using (go version)?

$ go version
go version go1.10.8 linux/amd64

Does this issue reproduce with the latest release?

No

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/achraf/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/achraf/devspace/fmle"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build919335073=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Try to get some package, for instance lint :
go get -u golang.org/x/lint/golint

What did you expect to see?

The package to be downloaded

What did you see instead?

# golang.org/x/tools/go/gcexportdata
/build/src/golang.org/x/tools/go/gcexportdata/gcexportdata.go:103:12: undefined: gcimporter.IExportData
@dstockton
Copy link

You'll need to install musl-dev in your build system.
You might want to think about upgrading the golang version to 1.12 too?

@Aazhar
Copy link
Author

Aazhar commented Oct 4, 2019

I tried to install musl-dev on my build system, I'm having the same problem.
We are planning to upgrade golang version but not soon, we need to try to fix this in the meantime.

@bcmills
Copy link
Contributor

bcmills commented Oct 4, 2019

CC @mdempsky @ianthehat @matloob

@bcmills bcmills changed the title undefined: gcimporter.IExportData x/tools/go/gcexportdata: 'undefined: gcimporter.IExportData' Oct 4, 2019
@gopherbot gopherbot added this to the Unreleased milestone Oct 4, 2019
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 4, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Oct 4, 2019
@ianlancetaylor
Copy link
Contributor

The problem is that x/tools/go/internal/gcimporter/iexport.go has a go1.11 build tag, and nothing else defines IExportData. While technically we only support the last two Go releases, it would be nice to support the 1.10 release if it's easy. From a quick test it looks like we could simply change the call to Embedded to call Anonymous instead. Embedded is the new name, Anonymous is the backward compatible name.

@lootch
Copy link

lootch commented Oct 4, 2019 via email

@stamblerre
Copy link
Contributor

I will make the change that @ianlancetaylor suggested.

@gopherbot
Copy link

Change https://golang.org/cl/199037 mentions this issue: go/internal/gcimporter: support Go versions < 1.11

rberg2 added a commit to rberg2/sawtooth-core that referenced this issue Oct 4, 2019
golang/go#34689

Signed-off-by: Richard Berg <rberg@bitwise.io>
rberg2 added a commit to rberg2/sawtooth-core that referenced this issue Oct 4, 2019
golang/go#34689

Signed-off-by: Richard Berg <rberg@bitwise.io>
@golang golang locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

7 participants