New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools: rewrite git history to remove 19 MB binary blob #34688
Comments
Was:
Now:
|
Done. (Temporarily added myself to |
This seems reasonable, thanks for doing that Brad. One new consideration compared to previous times are module versions. I think rewriting history may render pseudo-versions derived from commits that are no longer on master branch unusable when fetched directly from VCS:
They should still be available via the module mirror or another proxy, if cached in time. E.g.:
Otherwise people will need to change to a working updated pseudo-version. They'd only be affected if they updated to a very new pseudo-version in the short window of time that the rewrite touched. Given we're dealing with v0.0.0- pseudo-versions this seems okay in order to prune a large binary from history, but our options would be more limited when dealing with stable v1+ releases. In general, resolving #10658 will help with this. |
Note that for tagged releases, the Pseudo-versions are different because the commit metadata is embedded in the version string itself. |
https://go-review.googlesource.com/c/tools/+/198743 reverts a large binary that was checked in by mistake in https://golang.org/cl/198441
I filed #34687 to prevent this in the future, but this bug is about tracking rewriting the history away.
Previously:
/cc @andybons @dmitshur @toothrot @stamblerre @ianthehat
The text was updated successfully, but these errors were encountered: