Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

This PR (HEAD: 433ea7c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/198799 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198799.
After addressing review feedback, remember to publish your drafts!

Message from Matt Layher:

Patch Set 1: Code-Review-1

Sorry, I don't think this is a necessary addition to the standard library. Why not add this helper where you need it?

A proposal issue is the proper place to discuss this idea, rather than submitting a change.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198799.
After addressing review feedback, remember to publish your drafts!

Message from nrxr:

Patch Set 1:

Patch Set 1: Code-Review-1

Sorry, I don't think this is a necessary addition to the standard library. Why not add this helper where you need it?

A proposal issue is the proper place to discuss this idea, rather than submitting a change.

Hi Matt,

Indeed, I already have it as a helper for myself (see: https://github.com/nrxr/maskpass). My proposal for addition comes as I was listening today to the Go Time podcast about security (see: https://pca.st/nzc8wpta) and I saw more people could be using it as it's very common to output URLs to logs.

It was my thinking at the moment of writing the patch set that maybe having a log-friendly mode in the standard library for something as regularly used as URLs would be really helpful instead of leaving it to helpers.

I understand if it's deemed unnecessary, my intention was to propose a sensible default for something that may create security issues for a regular developer.

Let me know if the consensus is that I should be submitting this as a proposal issue instead and I'll do just that.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198799.
After addressing review feedback, remember to publish your drafts!