New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: infinite loop in LookupAddr() [1.13 backport] #34662
Comments
Change https://golang.org/cl/198489 mentions this issue: |
Closed by merging f262eed to release-branch.go1.13. |
If a request for a PTR record returned a response with a non-PTR answer, goLookupPTR would loop forever. Skipping non-PTR answers guarantees progress through the DNS response. Fixes #34662 Updates #34660 Change-Id: I56f9d21e5342d07e7d843d253267e93a29707904 Reviewed-on: https://go-review.googlesource.com/c/go/+/198460 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> (cherry picked from commit f0e940e) Reviewed-on: https://go-review.googlesource.com/c/go/+/198489 Reviewed-by: Michael Hendricks <michael@ndrix.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Is this fix still planned for backport to 1.13? It was assigned to milestone 1.13.2 then 1.13.3 but hasn't moved in the last two minor releases. I'd still like to see it in 1.13 someday, but definitely in 1.14. Thanks. |
@mndrix, you're commenting on a closed bug. The comments above show it was merged. And the Milestone says Go1.13.3 and it's in 1.13.3: https://go.googlesource.com/go/+log/refs/tags/go1.13.3 |
Sorry for my confusion about the process. Now I understand. Thanks for the clarification @bradfitz |
@bradfitz requested issue #34660 to be considered for backport to the next 1.13 minor release.
The text was updated successfully, but these errors were encountered: