Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/test: TestCommandLine broken in longtest builder due to missing 'patch' binary #34620

Closed
bcmills opened this issue Sep 30, 2019 · 2 comments
Closed

x/tools/gopls/test: TestCommandLine broken in longtest builder due to missing 'patch' binary #34620

bcmills opened this issue Sep 30, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 30, 2019

x/tools/gopls/test is currently failing in the longtest builder, apparently due to a missing patch binary:
https://build.golang.org/log/6c9781748c535cbcf9e49c00bba903963d107f20

It appears to have been broken at some point at or after CL 197717 and at or before CL 197158.

Please do at least one of the following:

  1. Add a Skip to the affected tests if the binary is not present,
  2. configure the longtest builder so that it has access to a patch binary, and/or
  3. roll back the CL that introduced the dependency on patch.
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Sep 30, 2019
@bcmills bcmills added this to the Go1.14 milestone Sep 30, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 30, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot
Copy link

Change https://golang.org/cl/199737 mentions this issue: internal/lsp: fix patch tests on builders

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@golang golang locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@rsc @ianthehat @bcmills @gopherbot