Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp: TestLSP/GOPATH/CompletionSnippets flake on darwin-amd64-10_14 builder #34617

Closed
bcmills opened this issue Sep 30, 2019 · 6 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 30, 2019

From the darwin-amd64-10_14 builder in https://build.golang.org/log/d8674baf25fbfd7a1da3118451ccb1b6efcedec2:

--- FAIL: TestLSP (240.36s)
    --- FAIL: TestLSP/GOPATH (189.27s)
        --- FAIL: TestLSP/GOPATH/CompletionSnippets (10.14s)
            --- FAIL: TestLSP/GOPATH/CompletionSnippets/deep_23_9_placeholders (10.00s)
                completion_test.go:42: /var/folders/9w/4l2_g3kx01x199n37fbmv3s80000gn/T/workdir-host-darwin-10_14/tmp/TestLSP_GOPATH313029317/lsp/src/golang.org/x/tools/internal/lsp/deep/deep.go:23:9-10: couldn't find completion matching "a.b"
FAIL
FAIL	golang.org/x/tools/internal/lsp	240.631s
@gopherbot gopherbot added this to the Unreleased milestone Sep 30, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 30, 2019
@stamblerre
Copy link
Contributor

It looks like this continues to happen. @muirrn: Any reason that you know of for that test to flake?

@muirdm
Copy link

muirdm commented Oct 25, 2019

My first thought would be completion running out of budgeted time and not performing the deep search, thus not finding the a.b candidate. That test sets the budget to 5 seconds, so it would have to be a major hiccup. We could try just turning up the budget or tweaking tests to have unlimited budget.

@muirdm
Copy link

muirdm commented Oct 25, 2019

I guess we do see that single test taking 10.00s in the output, so probably just the occasional slow run. I'll look at disabling the time limit for tests.

@gopherbot
Copy link

Change https://golang.org/cl/203338 mentions this issue: internal/lsp: disable completion time budget in tests

gopherbot pushed a commit to golang/tools that referenced this issue Oct 25, 2019
Now a budget of 0 disables mean unlimited and tests no longer set the
budget. Hopefully the deep completion tests will stop flaking.

Updates golang/go#34617

Change-Id: Icdff5e78dcf1cc3d3fcbf0326716b39b00f0a8c1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/203338
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@stamblerre
Copy link
Contributor

I believe the flakiness should be fixed as of the above CL.

@golang golang locked and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants