-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/internal/lsp: TestLSP/GOPATH/CompletionSnippets flake on darwin-amd64-10_14 builder #34617
Comments
Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here. |
It looks like this continues to happen. @muirrn: Any reason that you know of for that test to flake? |
My first thought would be completion running out of budgeted time and not performing the deep search, thus not finding the |
I guess we do see that single test taking |
Change https://golang.org/cl/203338 mentions this issue: |
Now a budget of 0 disables mean unlimited and tests no longer set the budget. Hopefully the deep completion tests will stop flaking. Updates golang/go#34617 Change-Id: Icdff5e78dcf1cc3d3fcbf0326716b39b00f0a8c1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/203338 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
I believe the flakiness should be fixed as of the above CL. |
From the
darwin-amd64-10_14
builder in https://build.golang.org/log/d8674baf25fbfd7a1da3118451ccb1b6efcedec2:The text was updated successfully, but these errors were encountered: