Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: OpenBSD: MAP_CONCEAL missing except on arm64 #34589

Closed
awnumar opened this issue Sep 28, 2019 · 2 comments
Closed

x/sys/unix: OpenBSD: MAP_CONCEAL missing except on arm64 #34589

awnumar opened this issue Sep 28, 2019 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@awnumar
Copy link
Contributor

awnumar commented Sep 28, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.9 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
xpslinux :: ~ » go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/awn/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/awn/src/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build069259099=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Received a report of a compile fail due to the MAP_CONCEAL flag being missing on OpenBSD.

What did you expect to see?

Expected to see it defined since it is supported on OpenBSD: https://man.openbsd.org/mmap.2#MAP_CONCEAL

What did you see instead?

A grep of the code-base shows that it is indeed defined, but only on ARM64: https://github.com/golang/sys/blob/2aa67d56cdd77167a5fb51358e8c3ce04bad68bb/unix/zerrors_openbsd_arm64.go#L927
@smasher164 smasher164 changed the title sys/unix: OpenBSD: MAP_CONCEAL missing except on arm64 x/sys/unix: OpenBSD: MAP_CONCEAL missing except on arm64 Sep 28, 2019
@gopherbot gopherbot added this to the Unreleased milestone Sep 28, 2019
@smasher164 smasher164 added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 28, 2019
@smasher164
Copy link
Member

smasher164 commented Sep 28, 2019 •
edited

./mkall.sh probably needs to be re-run on OpenBSD >= 6.5
/cc @ianlancetaylor @bradfitz @tklauser

awnumar added a commit to awnumar/memcall that referenced this issue Sep 30, 2019
@awnumar
patch: define MAP_CONCEAL locally until it is defined upstream
11bbaff 
Related to #1
Upstream issue: golang/go#34589
@gopherbot
Copy link

Change https://golang.org/cl/198157 mentions this issue: unix: update openbsd/{386,amd64.arm} MAP_* consts

@tklauser tklauser mentioned this issue Oct 2, 2019
Merged
@golang golang locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @awnumar @smasher164