Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: unified diff tests don't handle multi file patches #34580

Closed
ianthehat opened this issue Sep 27, 2019 · 2 comments
Closed

x/tools/gopls: unified diff tests don't handle multi file patches #34580

ianthehat opened this issue Sep 27, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@ianthehat
Copy link

we test unified diff output by attempting to apply the patch and seeing if we get the right result, we do this because the actual content of the patch does not matter and may vary, only the results of applying it can be verified to be correct.
because the only way to apply a multi-file patch is to modify the original files, we cannot easily do this in a test (single file mode writes to a different file instead)
we need to consider attempting to copy the files to a temporary directory to apply the patches to test this.
@gopherbot gopherbot added this to the Unreleased milestone Sep 27, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 27, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@stamblerre stamblerre modified the milestones: Unreleased, gopls unplanned Dec 4, 2019
@stamblerre stamblerre added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 13, 2020
@stamblerre stamblerre modified the milestones: gopls unplanned, gopls testing Jan 29, 2020
@stamblerre stamblerre added this to the Unreleased milestone Jan 29, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@findleyr
Copy link
Contributor

This may still be worth doing, but isn't in a priority and doesn't need to be tracked. Just cleaning up.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2022
@golang golang locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
4 participants
@ianthehat @stamblerre @gopherbot @findleyr