Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist: tar files are missing entries for directories #3458

Closed
rsc opened this issue Apr 2, 2012 · 5 comments
Closed

dist: tar files are missing entries for directories #3458

rsc opened this issue Apr 2, 2012 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.0.1

Comments

@rsc
Copy link
Contributor

rsc commented Apr 2, 2012 

What steps will reproduce the problem?
1. Download any tar file, say go.go1.linux-amd64.tar.gz.
2. tar tzvf go.go1.linux-amd64.tar.gz | grep '^d'

What is the expected output? What do you see instead?

Should see directories with permission 755.
Instead, there are no entries for directories.
Most tar programs will create the directories automatically,
but they may not make them world readable.
We should include the directory entries ourselves.

Please use labels and text to provide additional information.

Compare with 


$ cd $GOROOT
$ tar c test | tar tv | grep '^d'
drwxr-xr-x  0 rsc    eng         0 Apr  2 10:46 test/
drwxr-xr-x  0 rsc    eng         0 Dec 13 18:13 test/bench/
drwxr-xr-x  0 rsc    eng         0 Mar  7 11:35 test/bugs/
drwxr-xr-x  0 rsc    eng         0 Feb 19 15:22 test/chan/
drwxr-xr-x  0 rsc    eng         0 Feb 17 10:19 test/dwarf/
drwxr-xr-x  0 rsc    eng         0 Apr  2 10:46 test/fixedbugs/
drwxr-xr-x  0 rsc    eng         0 Mar 26 15:54 test/interface/
drwxr-xr-x  0 rsc    eng         0 Feb 26 13:15 test/ken/
drwxr-xr-x  0 rsc    eng         0 Feb 11 01:18 test/safe/
...
@rsc
Copy link
Contributor Author

rsc commented Apr 2, 2012

Comment 1:

See also comment #38 of https://golang.org/issue/3211.

@dsymonds
Copy link
Contributor

dsymonds commented Apr 3, 2012

Comment 2:

I think this applies to the zips too.

@davecheney
Copy link
Contributor

Comment 3:

Hello,
http://golang.org/cl/5969071
If you have already make a fix, please ignore this CL.
I have no access to windows machines so I cannot test, but the zip fix should work.
Cheers
Dave

@davecheney
Copy link
Contributor

Comment 4:

Hello,
http://golang.org/cl/5969071
If you have already made a fix, please ignore this CL.
I have no access to windows machines so I cannot test, but the zip fix should work.
Cheers
Dave

@adg
Copy link
Contributor

adg commented Apr 5, 2012

Comment 5:

This issue was closed by revision 4e9f704.

Status changed to Fixed.

@rsc rsc added fixed labels Apr 5, 2012
@rsc rsc assigned adg Apr 5, 2012
@rsc rsc added this to the Go1.0.1 milestone Apr 14, 2015
@rsc rsc removed the go1.0.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc unassigned adg Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.0.1
Development

No branches or pull requests
5 participants
@davecheney @dsymonds @rsc @adg @gopherbot