Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: make.bash broken on dwarf (on linux-mips64le builder) #34549

Closed
ALTree opened this issue Sep 26, 2019 · 4 comments
Closed

cmd/compile: make.bash broken on dwarf (on linux-mips64le builder) #34549

ALTree opened this issue Sep 26, 2019 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@ALTree
Copy link
Member

ALTree commented Sep 26, 2019 •
edited

The linux-mips64le-mengzhuo builder (and only that one) is currently broken, make.bash failing with:

# cmd/internal/obj
src/cmd/internal/obj/dwarf.go:57:18: cannot use dctxt (type dwCtxt) as type dwarf.Context in argument to dwarf.Uleb128put:
	dwCtxt does not implement dwarf.Context (wrong type for AddFileRef method)
		have AddFileRef(dwarf.Sym, interface {})
		want AddFileRef(dwarf.Sym, interface {})
src/cmd/internal/obj/dwarf.go:80:20: cannot use dctxt (type dwCtxt) as type dwarf.Context in argument to dwarf.Uleb128put:
	dwCtxt does not implement dwarf.Context (wrong type for AddFileRef method)
		have AddFileRef(dwarf.Sym, interface {})
		want AddFileRef(dwarf.Sym, interface {})

[...]
go tool dist: FAILED: /tmp/workdir-host-linux-mipsle-mengzhuo/go/pkg/tool/linux_mips64le/go_bootstrap install -gcflags=all= -ldflags=all= -a -i cmd/asm cmd/cgo cmd/compile cmd/link: exit status 2

Full log: https://build.golang.org/log/0d42c095b6c4f9ffc05afce41409fae19ba917eb

The failure started at 78baea8 (internal/bytealg: add assembly implementation of Compare / CompareString on mips64x), which seems unrelated.

cc @mengzhuo as builder owner and author of that commit
cc @jeremyfaller @aclements for runtime and dwarf
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 26, 2019
@ALTree ALTree added this to the Go1.14 milestone Sep 26, 2019
@mengzhuo
Copy link
Contributor

My bad.
Will look into it.

@gopherbot
Copy link

Change https://golang.org/cl/197557 mentions this issue: internal/bytealg: fix mips64x wrong compare implement

@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 28, 2019
@gopherbot
Copy link

Change https://golang.org/cl/198358 mentions this issue: bytes: add endian base compare test

@mdempsky
Copy link
Member

mdempsky commented Oct 3, 2019

Seems like this was fixed?

gopherbot pushed a commit that referenced this issue Oct 7, 2019
@mengzhuo @cherrymui
bytes: add endian base compare test
fc2915f 
The current bytes test suit didn't come with endian based test
which causing #34549 can passed the try-bot.
This test will failed when little endian architecture simply using
load and compare uint.

Update #34549

Change-Id: I0973c2cd505ce21c2bed1deeb7d526f1e872118d
Reviewed-on: https://go-review.googlesource.com/c/go/+/198358
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@mdempsky @mengzhuo @ALTree @gopherbot