x/build/cmd/tip: installs x/website/cmd/golangorg from internet instead of the cloned commit #34545
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
modules
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
The
golangorgBuilder.Init
method ofcmd/tip
dutifully clones the provided to it revision of thewebsite
repository to disk... and then proceeds to completely ignore that revision and just installs the latest version from the internet instead.That is quite silly; it shouldn't do that.
(It's not very harmful because the intention of
golangorgBuilder.Init
is to fetch and use the lastest HEAD ofgo
andwebsite
repositories, but in addition to doing same work twice, it also means there's a small chance the x/website revision reported by the/_tipstatus
endpoint would be slightly off.)I spotted this problem after debugging issue #34526 and then seeing the following in cmd/tip production logs:
The text was updated successfully, but these errors were encountered: