Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: Exec doesn't propagate error from subsetTypeArgs #3449

Closed
gopherbot opened this issue Mar 31, 2012 · 6 comments
Closed

database/sql: Exec doesn't propagate error from subsetTypeArgs #3449

gopherbot opened this issue Mar 31, 2012 · 6 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

by lewis@squareup.com:

When calling conn.Exec and passing invalid arguments, it doesn't propagate the error.

Attached a patch.

Attachments:

  1. fix.patch (485 bytes)
@bradfitz
Copy link
Contributor

bradfitz commented Apr 1, 2012

Comment 1:

Owner changed to @bradfitz.

Status changed to Accepted.

@bradfitz
Copy link
Contributor

bradfitz commented Apr 3, 2012

Comment 2:

Lewis, thanks.  This is a trivial enough change that I can make it myself under my name,
but if you'd like it committed as you, you'll need to first complete a CLA:
See http://golang.org/doc/contribute.html#copyright
(also see the rest of that page... we don't attach patches to the bug tracker as part of
our codereview/workflow.)
Let me know how you'd like to proceed.

@gopherbot
Copy link
Author

Comment 3 by mikelikespie:

Sorry, posted this originally  under the wrong google code account.   I followed the
directions (as best I could). 
Signed the CLA under mikelikespie@gmail.com
Created this http://golang.org/cl/5970076

@bradfitz
Copy link
Contributor

bradfitz commented Apr 3, 2012

Comment 4:

Okay, I've submitted your CLA.
I think you just forgot to run "hg mail 5970076" to send it out to the golang-dev list. 
I don't see it there, nor in the moderation queue.
(I promise this gets less painful after the first time.)

@bradfitz
Copy link
Contributor

bradfitz commented Apr 3, 2012

Comment 5:

This issue was closed by revision 86092b3.

Status changed to Fixed.

@rsc
Copy link
Contributor

rsc commented Apr 25, 2012

Comment 6:

This issue was closed by revision c975af4a52fe.

@mikioh mikioh changed the title database/sql's Exec doesn't propagate error from subsetTypeArgs database/sql: Exec doesn't propagate error from subsetTypeArgs Feb 18, 2015
bradfitz pushed a commit that referenced this issue May 11, 2015
@mikelikespie @bradfitz
[release-branch.go1] sql: Propagate error from subsetTypeArgs in Exec
ca24622 
««« backport dd8f13acda2e
sql: Propagate error from subsetTypeArgs in Exec

Fixes #3449

R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/5970076

»»»
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot