Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/cmd/golangorg, x/build/cmd/tip: inconsistent tabwidth value #34448

Closed
dmitshur opened this issue Sep 21, 2019 · 4 comments
Closed

x/website/cmd/golangorg, x/build/cmd/tip: inconsistent tabwidth value #34448

dmitshur opened this issue Sep 21, 2019 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

https://tip.golang.org uses the default godoc presentation tab width of 4, but https://golang.org uses a tab width of 8 (because it's being overridden in appinit.go). This results in inconsistent rendering.

https://tip.golang.org/pkg/runtime/debug/#GCStats:

image

https://golang.org/pkg/runtime/debug/#GCStats:

image

They should use the same value. We need to decide which.

/cc @andybons @julieqiu
@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Sep 21, 2019
@dmitshur dmitshur added this to the Unreleased milestone Sep 21, 2019
@dmitshur dmitshur self-assigned this Sep 21, 2019
@dmitshur
Copy link
Contributor Author

I would prefer going with 4 everywhere, because 8 is quite wide, and 4 seems more commonly used. The future discovery site (issue #33654) and godoc.org currently use a tab width of 4:

https://godoc.org/runtime/debug#GCStats:

image

But I also realize this is a subjective preference.

@andybons
Copy link
Member

4 is fine

@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Sep 22, 2019
@gopherbot
Copy link

Change https://golang.org/cl/196937 mentions this issue: cmd/golangorg: change tab width from 8 to 4 in production

@dmitshur
Copy link
Contributor Author

This fix is deployed.

@golang golang locked and limited conversation to collaborators Sep 22, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
cmd/golangorg: change tab width from 8 to 4 in production
7ffa4dd 
Remove the override, use the default godoc.Presentation value of 4.
This increases consistency across various Go websites, and reduces
the amount of blank horizontal space use.

Fixes golang/go#34448

Change-Id: Ie3e40f13e6275e74e79c46bbc242d4e5ad95ffda
Reviewed-on: https://go-review.googlesource.com/c/website/+/196937
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @dmitshur @gopherbot