Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review: git codereview mail uses wrong email #34411

Closed
rileykarson opened this issue Sep 19, 2019 · 3 comments
Closed

x/review: git codereview mail uses wrong email #34411

rileykarson opened this issue Sep 19, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@rileykarson
Copy link

What version of Go are you using (go version)?

$ go version

go version go1.12.1 darwin/amd64

Does this issue reproduce with the latest release?

N/A

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/rileykarson/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/rileykarson/go-workspace"
GOPROXY=""
GORACE=""
GOROOT="/Users/rileykarson/homebrew/opt/go/libexec"
GOTMPDIR=""
GOTOOLDIR="/Users/rileykarson/homebrew/opt/go/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/81/zf5_7yzn1sxg_7kfkqsvgclw00cn8c/T/go-build474690330=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

git codereview mail

Following this guide: https://code.googlesource.com/gocloud/+/refs/heads/master/CONTRIBUTING.md#contributing

git log:

commit 795c92268c930c8714d3b6a4bfe1a173a1858b4a (HEAD -> add-storage-type-to-read)
Author: Riley Karson <rileykarson@google.com>
Date:   Thu Sep 19 09:53:40 2019 -0700

    bigtable: Add StorageType to ClusterInfo

    Change-Id: I7120f3ae6c4e5fdb48744613cd222eef317d841e

What did you expect to see?

Success, using my Git email on this machine, rileykarson@google.com

What did you see instead?

$ git codereview mail
fatal: remote error: PERMISSION_DENIED The caller does not have permission
[type.googleapis.com/google.rpc.LocalizedMessage]
locale: "en-US"
message: "No Contributor Agreement on file for user Riley Karson <rileykarson@gmail.com> (id=17848)"

[type.googleapis.com/google.rpc.RequestInfo]
request_id: "1002a9a0037c424fbd703c9708d4ae78"

[type.googleapis.com/google.rpc.RequestInfo]
request_id: "677d29bf9bf940e0aa432dedde6dff78"

(running: git push -q origin HEAD:refs/for/master)
/Users/rileykarson/go-workspace/bin/git-codereview: exit status 128
@gopherbot gopherbot added this to the Unreleased milestone Sep 19, 2019
@andybons
Copy link
Member

Does the same message appear if you try to upload the change directly via:

git push origin HEAD:refs/for/master

?

@andybons andybons added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Sep 19, 2019
@rileykarson
Copy link
Author

Ah, yep.

It looks like the value is being sourced from my .gitcookies file when I'd used that email to get a token for a go get cookie months back. Removing it from there caused the correct email to be used.

@andybons
Copy link
Member

Closing as it seems that this is not an issue with git-codereview. Please comment if you feel that’s not the case.

@golang golang locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @rileykarson @gopherbot