Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Transport.RoundTrip occasionally stalls when using http2client #34401

Closed
grudzinski opened this issue Sep 19, 2019 · 3 comments
Closed

net/http: Transport.RoundTrip occasionally stalls when using http2client #34401

grudzinski opened this issue Sep 19, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unplanned

Comments

@grudzinski
Copy link

grudzinski commented Sep 19, 2019 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.13 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/romang/.cache/go-build"
GOENV="/home/romang/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/romang/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/romang/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/romang/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build443134527=/tmp/go-build -gno-record-gcc-switches"

What did you do?

My server is doing a lot of requests to another servers.

What did you expect to see?

A normal work. It works OK when http2client is disabled.

What did you see instead?

A lot of unexpected goroutines locked in go http2 implementation.

Screen Shot 2019-09-19 at 15 18 20

See the diff of profiles, this is the problem stacktrace, diff is about 1:30.
@andybons andybons changed the title x/net/http2: net/http: Transport.RoundTrip occasionally stalls when using http2client Sep 19, 2019
@andybons
Copy link
Member

Without any code it is extremely difficult to help you diagnose this issue. Can you provide any more information?

@bcmills @rsc due to recent work on net/http Transport.

@andybons andybons added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Sep 19, 2019
@andybons andybons added this to the Unplanned milestone Sep 19, 2019
@bcmills
Copy link
Contributor

bcmills commented Sep 19, 2019

The changes that Russ and I made should not affect HTTP/2, and shouldn't have any effect on the (*Client).send part of the RoundTrip call anyway.

@grudzinski, did this stall occur with previous go versions, or was this a regression in 1.13?

@bcmills bcmills added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Sep 19, 2019
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@andybons @grudzinski @bcmills @gopherbot