Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: new internal/goroot test broke aix, illumos, solaris builders #34390

Closed
ALTree opened this issue Sep 19, 2019 · 3 comments
Closed

cmd/go: new internal/goroot test broke aix, illumos, solaris builders #34390

ALTree opened this issue Sep 19, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.14

Comments

@ALTree
Copy link
Member

ALTree commented Sep 19, 2019 •
edited

The new internal/goroot mod_m test introduced in CL 196120 with the fix for #34358 is currently failing on the aix, illumos, and solaris builders, with the following error:

--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/mod_m (4.13s)
        script_test.go:191: 
            # It's absurd, but builds with -compiler=gccgo used to fail to build module m.
            # golang.org/issue/34358 (3.875s)
            > cd m
            $WORK/gopath/src/m
            > go build
            > exists m$GOEXE
            > rm m$GOEXE
            > [exec:gccgo] go build -compiler=gccgo
            [stderr]
            # m
            ld: 0711-317 ERROR: Undefined symbol: .runtime.setmodinfo
            ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information.
            collect2: error: ld returned 8 exit status
            [exit status 2]
            FAIL: testdata/script/mod_m.txt:8: unexpected command failure
            
FAIL
FAIL	cmd/go	107.473s
FAIL

cc @ianlancetaylor
@ALTree ALTree added this to the Go1.14 milestone Sep 19, 2019
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 19, 2019
@Helflym
Copy link
Contributor

Helflym commented Sep 19, 2019

I think this is linked with CL 196237. Symbol runtime.setmodinfo is only available in gcc-master with go1.13. In previous gcc version thus previous Go version, runtime/debug.setmodinfo is still linked to runtime..z2fdebug.setmodinfo.

gcc-9.1.0:

go/runtime/debug/mod.go://go:linkname setmodinfo runtime..z2fdebug.setmodinfo

gcc-svn:

go/runtime/debug.go://go:linkname setmodinfo runtime.setmodinfo

Thus, gccgo version must be checked when creating _gomod_.go.

AIX builder is still in gcc 8 (for various reasons) and I think it's the same for Illumos and Solaris builders.

@av86743
Copy link

av86743 commented Sep 19, 2019

Are trybots' gccgo/gcc out of sync with builders?

@ALTree
Copy link
Member Author

ALTree commented Sep 19, 2019

Fixed by https://go-review.googlesource.com/c/go/+/196518

@ALTree ALTree closed this as completed Sep 19, 2019
@golang golang locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@av86743 @ALTree @gopherbot @Helflym