New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/gopherbot: opt-out changes from Gerrit approvers
list from automatically adding reviewers
#34362
Comments
One workaround is to use |
CC @andybons |
To clarify, the workaround you're suggesting here is to use the -r flag to specify reviewers at upload time, or to add myself as the reviewer specifically? (I only use
I usually prefer to wait until I've confirmed that my CL passes trybots before sending them to reviewers. Also, part of the problem is when I upload a patch series, I want to mail out the patches in order and at a pace that I feel confident my reviewers can keep up with. I don't want to mail them all out right away. |
Have you considered marking the CL as a WIP until it's ready for review? I don't think |
Stepping back, are we actually getting value out of the auto-assignment of CLs? |
@andybons I do think there's some value in making sure that CLs don't go unnoticed in between all the activity. But that only applies to CLs that go unnoticed to begin with. Maybe gopherbot could simply wait 48h to assign reviewers if there are none; that's plenty of time for an author to run the tests, or assign reviewers, or whatever they decide to do. |
@mvdan assigning after 48hrs automatically could create confusion (do we add messaging for every change letting people know? Only to new contributors?). I'd rather us move to a pull model where one could find owners via a Gerrit UI plugin and assign themselves. It would be straightforward to implement as dev.golang.org/owners supports CORS requests. |
I do think it's important that the bot give contributors some idea of how to proceed with their CL and when to expect that it will be reviewed. (I know I'm pretty terrible at keeping up with I don't feel strongly about whether that should take the form of auto-assignment or a nudge toward some self-service page or tool. |
What about instead removing it for all google.com and golang.org users? |
(to slightly amend Brad's idea, I think using the approvers list would be slightly better, so that non-googlers can also benefit) |
Oh, what @mvdan says would be even better. |
Change https://golang.org/cl/196138 mentions this issue: |
Updates golang/go#34362. Change-Id: I2a1861d7ebb903d0231a7670597467b02d53ac96 Reviewed-on: https://go-review.googlesource.com/c/build/+/196138 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
approvers
list from automatically adding reviewers
Opting-out for all approvers sounds reasonable to me. I just didn't want to be presumptive about whether others feel the same as I do about Gopherbot automatically adding reviewers to my CLs. (E.g., I know that as someone who pushes CLs directly to Gerrit using |
Updates golang/go#34362. Change-Id: I2a1861d7ebb903d0231a7670597467b02d53ac96 Reviewed-on: https://go-review.googlesource.com/c/build/+/196138 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I'd rather gopherbot stopped automatically adding reviewers to my CLs.
I appreciate the intent, and I think it's a great idea for people who are new to contributing to Go. But I'm comfortable using Gerrit and finding reviewers, and I don't want my reviewers confused because Gopherbot asked them to look at my CLs out of order.
The text was updated successfully, but these errors were encountered: