Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: panic in ParseGoHandle #34359

Closed
muirdm opened this issue Sep 17, 2019 · 3 comments
Closed

x/tools/gopls: panic in ParseGoHandle #34359

muirdm opened this issue Sep 17, 2019 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@muirdm
Copy link

muirdm commented Sep 17, 2019

Starting getting this panic as I was trying to reproduce an unsaved overlay file issue (on master d997db1):

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x156ee89]

goroutine 6863 [running]:
go/ast.(*File).Pos(...)
	/usr/local/go/src/go/ast/ast.go:997
golang.org/x/tools/internal/lsp/cache.(*cache).ParseGoHandle.func1(0x17e4380, 0xc001a6a6c0, 0x1723f80, 0xc00ec53500)
	/Users/muir/projects/tools/internal/lsp/cache/parse.go:57 +0x119
golang.org/x/tools/internal/memoize.(*Handle).run.func1(0xc0044d27d0, 0x17e4380, 0xc001a6a6c0)
	/Users/muir/projects/tools/internal/memoize/memoize.go:181 +0x3e
created by golang.org/x/tools/internal/memoize.(*Handle).run
	/Users/muir/projects/tools/internal/memoize/memoize.go:178 +0xfe
@gopherbot gopherbot added this to the Unreleased milestone Sep 17, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 17, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here.

@stamblerre
Copy link
Contributor

I think this will be fixed with https://go-review.googlesource.com/c/tools/+/195997.

@muirdm
Copy link
Author

muirdm commented Sep 17, 2019

Thanks - seems to not happen anymore. Will reopen if I see it again.

@muirdm muirdm closed this as completed Sep 17, 2019
@golang golang locked and limited conversation to collaborators Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @muirdm