Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: 'go list -test' prints main package twice [1.13 backport] #34328

Closed
gopherbot opened this issue Sep 16, 2019 · 5 comments
Closed

cmd/go: 'go list -test' prints main package twice [1.13 backport] #34328

gopherbot opened this issue Sep 16, 2019 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@jayconrod requested issue #34321 to be considered for backport to the next 1.13 minor release.

@gopherbot Please backport to 1.13.1.

CL 195281 is a cherry-pick of CL 195279, which will introduce this issue. These CLs should be cherry-picked together.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 16, 2019
@gopherbot gopherbot mentioned this issue Sep 16, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 16, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/197064 mentions this issue: [release-branch.go1.13] cmd/go: don't split internal test main packages twice

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Sep 25, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 25, 2019
@gopherbot
Copy link
Author

Closed by merging 94227d2 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Sep 25, 2019
[release-branch.go1.13] cmd/go: don't split internal test main packag…
94227d2 
…es twice

Fixes #34328

Change-Id: Ia6253038c525089e20a1da64a2c5c9dcc57edd74
Reviewed-on: https://go-review.googlesource.com/c/go/+/195677
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 4d18a7c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/197064
Run-TryBot: Bryan C. Mills <bcmills@google.com>
@bcmills
Copy link
Contributor

bcmills commented Sep 25, 2019

Approved as a companion to #34223, which was a regression.

@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@lanfengye2008
Copy link

Version 1.13.1 has not been fixed

@bcmills
Copy link
Contributor

bcmills commented Sep 26, 2019

@lanfengye2008, that is intentional — 1.13.1 is a security release, which includes only security fixes. There is a reason I updated this issue's milestone.

@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @katiehockman @lanfengye2008