Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: working directory affects binaries even with -trimpath [1.13 backport] #34326

Closed
gopherbot opened this issue Sep 16, 2019 · 3 comments
Closed

cmd/go: working directory affects binaries even with -trimpath [1.13 backport] #34326

gopherbot opened this issue Sep 16, 2019 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link
Contributor

@FiloSottile requested issue #33772 to be considered for backport to the next 1.13 minor release.

I'd like this to be considered for backport to Go 1.13 (@gopherbot, please do the honors).

There is no real workaround to get the functionality of -trimpath without this fix, which AFAICT was added specifically for reproducible builds.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 16, 2019
@gopherbot gopherbot mentioned this issue Sep 16, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 16, 2019
@samuelkarp samuelkarp mentioned this issue Sep 19, 2019
Open
@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Oct 1, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 1, 2019
@toothrot
Copy link
Contributor

toothrot commented Oct 1, 2019

Approving. This was documented as a feature in 1.13, and does not work without this fix.

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/198259 mentions this issue: [release-branch.go1.13] cmd/go: don't include package dir in cache key when -trimpath is set

@gopherbot
Copy link
Contributor Author

Closed by merging 8c8a881 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Oct 1, 2019
[release-branch.go1.13] cmd/go: don't include package dir in cache ke…
8c8a881 
…y when -trimpath is set

The '-trimpath' flag tells 'go build' to trim any paths from the
output files that are tied to the current workspace or toolchain. When
this flag is set, we do not need to include the package directory in
the text hashed to construct the action ID for each package.

Updates #33772
Fixes #34326

Change-Id: I20b902d2f58019709b15864ca79aa0d9255ae707
Reviewed-on: https://go-review.googlesource.com/c/go/+/195318
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit aa680c0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/198259
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
@bcmills bcmills mentioned this issue Oct 11, 2019
Closed
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
tjanez added a commit to oasisprotocol/oasis-core that referenced this issue Dec 13, 2019
@tjanez
go: Remove -ldflags=-buildid= workaround
de00f33 
The fix for golang/go#33772 has been
backported to Go 1.13 (golang/go#34326) and
is included in the Go 1.13.4 release.
tjanez added a commit to oasisprotocol/oasis-core that referenced this issue Dec 16, 2019
@tjanez
go: Remove -ldflags=-buildid= workaround
60641ce 
The fix for golang/go#33772 has been
backported to Go 1.13 (golang/go#34326) and
is included in the Go 1.13.4 release.
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
4 participants
@toothrot @bcmills @gopherbot @katiehockman