New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: 'go list -test' prints main package twice #34321
Comments
Change https://golang.org/cl/195617 mentions this issue: |
CL 195617 produced some more debug information:
The diff: &packages.jsonPackage{
[...]
- DepOnly:true,
+ DepOnly:false,
[...]
} |
I'm able to reproduce it locally on tip. It doesn't reproduce on earlier versions of go. (To reproduce locally you'll have to set your PATH to include tip go because go/packages starts |
I figured out why it was failing to reproduce for me. I made the mistake of doing this:
Instead of something else that would do what I actually intended:
🤦♂ Oh well, mystery solved. Thanks @matloob, your comment helped me figure it out. |
This was caused by CL 195279. Sorry for the break! (I wish we ran tools tests as a presubmit). When the go command loads test packages, it needs to recompile packages that transitively import internal test packages. There are a couple extra rules for After CL 195279, it appears that internal test |
Change https://golang.org/cl/195677 mentions this issue: |
@gopherbot Please backport to 1.13.1. CL 195281 is a cherry-pick of CL 195279, which will introduce this issue. These CLs should be cherry-picked together. |
Backport issue(s) opened: #34328 (for 1.13). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
From https://build.golang.org/?repo=golang.org%2fx%2ftools, it looks like the failure started to happen roughly close to 24781a1, but that might not be the exact commit.
Unfortunately, I can't reproduce it locally yet. For now, I'll send a CL to get more debug info out of the builders where it reproduces easily.
/cc @jayconrod @matloob
The text was updated successfully, but these errors were encountered: