New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/build: ImportDir accepts directories that don't exist #3428
Comments
Labels changed: added priority-soon, removed priority-triage. Owner changed to @rsc. Status changed to Accepted. |
https://golang.org/cl/7129048 Owner changed to @adg. Status changed to Started. |
This issue was closed by revision 9413a6f. Status changed to Fixed. |
Let my try and address the godoc stuff (issue #4330) without this fix, then we'll see if the behavior should change. In the meantime I'll remove the cruft from go/build, as the real fix may be something different and more subtle. |
So I've reapplied @adg's previously reverted fix in 9413a6f on tip 9d7c9b4. and all the net/* tests pass. I don't have trybot running access so can't test it out more via a CL. Should we be taking a look at this more or is this low priority? Am at $ git log | head -n 1
commit 9d7c9b4384db01afd2acb27d3a4636b60e957f08
$ go version
go version devel +9d7c9b4 Sat May 7 08:00:39 2016 +0000 darwin/amd64 |
Okay I've run them all on my computer and can confirm that all the tests pass with @adg's previous fix at least on $ uname -a
Darwin Emmanuels-MacBook-Pro-2.local 15.4.0 Darwin Kernel Version 15.4.0: Fri Feb 26 22:08:05 PST 2016; root:xnu-3248.40.184~3/RELEASE_X86_64 x86_64 Would you like me to send a CL or would you @adg like to do the honours since it is your fix? |
@odeke-em pleas send a CL. |
@odeke-em does godoc work, though? |
Aye aye, let me get this in then, thanks. Yes godoc works, please see this gist https://gist.github.com/odeke-em/0fe427ceabb2296fae37c5b0c61b433f. |
CL https://golang.org/cl/23013 mentions this issue. |
The text was updated successfully, but these errors were encountered: