Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get fails when repository ends with .go [1.13 backport] #34243

Closed
gopherbot opened this issue Sep 11, 2019 · 4 comments
Closed

cmd/go: go get fails when repository ends with .go [1.13 backport] #34243

gopherbot opened this issue Sep 11, 2019 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@jayconrod requested issue #32483 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport to 1.13, this was a regression
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 11, 2019
@gopherbot gopherbot mentioned this issue Sep 11, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 11, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/194687 mentions this issue: [release-branch.go1.13] cmd/go: strip trailing slash from versioned arguments

@jayconrod
Copy link
Contributor

This was a regression in 1.13. A workaround is possible, but it's subtle and difficult to discover, and the fix is small.

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Sep 11, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 11, 2019
@gopherbot
Copy link
Author

Closed by merging f0c6230 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Sep 11, 2019
[release-branch.go1.13] cmd/go: strip trailing slash from versioned a…
f0c6230 
…rguments

'go get' accepts arguments of the form path@version, and it passes
them through search.CleanPatterns before querying proxies. With this
change, CleanPatterns preserves text after '@' and will strip trailing
slashes from the patn.

Previously, we did not strip trailing slashes when a version was
present, which caused proxy base URL validation to fail. Module paths
that end with ".go" (for example, github.com/nats-io/nats.go) use
trailing slashes to prevent 'go build' and other commands from
interpreting packages as source file names, so this caused unnecessary
problems for them.

Fixes #34243

Change-Id: Id3730c52089e52f1cac446617c20132a3021a808
Reviewed-on: https://go-review.googlesource.com/c/go/+/194600
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 8875fb9)
Reviewed-on: https://go-review.googlesource.com/c/go/+/194687
@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@bcmills bcmills mentioned this issue Oct 4, 2019
Closed
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@derekcollison
Copy link

Thank you! 🎉

@golang golang locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
5 participants
@derekcollison @jayconrod @bcmills @gopherbot @katiehockman