Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: experimentalDisabledAnalyses doesn't work anymore #34242

Closed
inliquid opened this issue Sep 11, 2019 · 4 comments
Closed

x/tools/gopls: experimentalDisabledAnalyses doesn't work anymore #34242

inliquid opened this issue Sep 11, 2019 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Milestone

Comments

@inliquid
Copy link

inliquid commented Sep 11, 2019

I was using this setting for quite a while as per #31717

"gopls": {
    ...
    "experimentalDisabledAnalyses": ["composites"],
    ...
}

But with recent update from master it suddenly stopped working and I can see this garbage:
изображение

@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Sep 11, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here.

@inliquid inliquid changed the title x/tools/gopls: experimentalDisabledAnalyses doen't work anymore x/tools/gopls: experimentalDisabledAnalyses doesn't work anymore Sep 11, 2019
@stamblerre
Copy link
Contributor

This was a mistake that crept into https://go-review.googlesource.com/c/tools/+/194278. Fixed in https://go-review.googlesource.com/c/tools/+/194682.

We definitely need to add some tests to avoid regressions with the configuration options. I'll open a new issue.

@inliquid
Copy link
Author

@stamblerre sorry, but it still doesn't work.

@stamblerre
Copy link
Contributor

Ah sorry, should be fixed for real on master now (https://go-review.googlesource.com/c/tools/+/194818).

@golang golang locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Development

No branches or pull requests

4 participants
@stamblerre @inliquid @gopherbot and others