Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: the "Go 1.12.x" suffix for trybots sometimes disappears #34234

Closed
dmitshur opened this issue Sep 11, 2019 · 4 comments
Closed

x/build/cmd/coordinator: the "Go 1.12.x" suffix for trybots sometimes disappears #34234

dmitshur opened this issue Sep 11, 2019 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 11, 2019 •
edited

Trybots test on non-main repos by running on go tip and we have 2 builders that test the 2 current releases (1.13.x and 1.12.x). Those builders are supposed to have a suffix in the title so people can tell them apart, e.g.:

linux-amd64
linux-amd64 (Go 1.13.x)
linux-amd64 (Go 1.12.x)

I've noticed some trybot reports do not include the "Go 1.12.x" suffix in some occasions. For example:

https://go-review.googlesource.com/c/tools/+/191018/5#message-3523913181223269365a639f2de619f97c9748b8

Note it says:

2 of 10 TryBots failed:
Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/83bd8812/linux-amd64_473638fb.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/61a5d114/linux-amd64_e368aff8.log

The second "linux-amd64" line should've been "linux-amd64 (Go 1.12.x)" because commit 61a5d11 is on 1.12 release branch, not master.

/cc @bradfitz @toothrot
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 11, 2019
@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2019
@dmitshur
Copy link
Contributor Author

dmitshur commented Sep 11, 2019 •
edited

I've seen it happen to my own trybot run just now:


image

Note that it says "linux-amd64 rev cf06b9aa", which is clearly a 1.12.x commit.

I think I have a lead where to start the investigation.

It seems to happen when a trybot builder is restarted due to a communication error. Specifically, I saw the "linux-amd64 (Go 1.12.x)" builder get a "failed to get a buildlet in 5 minutes" failure, and when it restarted, it said "linux-amd64" without the suffix.

The name is computed in buildStatus.NameAndBranch method, which looks correct.

So the issue is likely that the goBranch isn't set (or maybe the NameAndBranch method isn't called) when a trybot builder is restarted.

@bradfitz
Copy link
Contributor

Again:

Screen Shot 2019-10-23 at 9 40 42 PM

@dmitshur
Copy link
Contributor Author

/cc @cagedmantis This might be a tricky one, but see if you'd like to investigate it.

@gopherbot
Copy link

Change https://golang.org/cl/204597 mentions this issue: cmd/coordinator: fix occasionally disappearing branch suffixes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 31, 2019
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@bradfitz @codebien
cmd/coordinator: fix occasionally disappearing branch suffixes
4b0d40c 
Fixes golang/go#34234

Change-Id: I2dcd48a9e3900fad9916103737b47d945256faa7
Reviewed-on: https://go-review.googlesource.com/c/build/+/204597
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot