x/tools/gopls: 'span' should support the import module path with upper-case #34230
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
WaitingForInfo
Issue is not actionable because of missing required information, which needs to be provided.
Milestone
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Clone https://github.com/nytimes/gizmo and put gizmo under module mode, jump to definition for gizmo/pubsub/kafka/config.go:
Config *sarama.Config
.What did you expect to see?
The expected trace log for the definition jump.
What did you see instead?
There is %21 in the uri. %21 corresponds to "!", the exclamation mark is intended, see #26456.
vscode-go can handle this because of https://github.com/microsoft/vscode/blob/master/src/vs/base/common/uri.ts#L478. However I think it would be better convert the %21 back to ! when gopls reply the result to the clients.
The text was updated successfully, but these errors were encountered: