Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/playground: Please bring color and editor to playground #34227

Open
dackon opened this issue Sep 11, 2019 · 7 comments
Open

x/playground: Please bring color and editor to playground #34227

dackon opened this issue Sep 11, 2019 · 7 comments
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@dackon
Copy link

dackon commented Sep 11, 2019

Currently, the playground is yellow background and black text, make it difficult to read the codes. Can you make codes colorful and bring editor to playground (like Wandbox) ?

@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2019
@ALTree
Copy link
Member

ALTree commented Sep 11, 2019

This was asked in the past. The most relevant discussion is at #28539.

To sum it up:

Essentially: it appears that adding syntax colouring for the playground would be okay, but someone needs to do the work and without using a beefy 3rd party lib like the one the tour uses.

@dackon
Copy link
Author

dackon commented Sep 11, 2019

Duplicate of #28539.

@dackon dackon closed this as completed Sep 11, 2019
@ALTree
Copy link
Member

ALTree commented Sep 11, 2019

#28539 is closed. This should be left open as the canonical reference for this work.

@ALTree ALTree reopened this Sep 11, 2019
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 16, 2019
@beoran
Copy link

beoran commented Sep 20, 2019

I think we could base ourselves on MicroLight: https://asvd.github.io/microlight/ , but change it so it recognises Go code only specifically. This also has the advantage that it highlights syntax without using color, only using font effects or a literal highlight effect.

@WoodpeckerBaby
Copy link

If it can be made to look like the default vscode, that would be great.

@suriya-ganesh
Copy link

Is this issue still open? I would like to take a stab at this.

@beoran
Copy link

beoran commented Sep 19, 2021

It is still open but ALTree has requested that this should be implemented using a very light weight library. That's why I proposed MicroLight which has the advantage that it is tiny and it also works also for color blind people like myself because it uses syntax styling instead of colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

8 participants