Skip to content

x/text/unicode/norm: TestLinking consistently failing on multiple builders #34209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Sep 10, 2019 · 8 comments
Closed

x/text/unicode/norm: TestLinking consistently failing on multiple builders #34209

bcmills opened this issue Sep 10, 2019 · 8 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 10, 2019

See previously #32843.

TestLinking appears to be failing consistently on the following builders:

The failures are all similar, but the reported numbers vary by platform.

If a test failure on these platforms is expected, the test should be skipped.
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Sep 10, 2019
@rsc
Copy link
Contributor

rsc commented Oct 29, 2019

/cc @dr2chase @cherrymui @jeremyfaller
Maybe this test failure is real and the linker is failing to eliminate data it used to?

@dmitshur
Copy link
Contributor

Friendly ping.

This issue currently has the label Soon, which is for regressions, serious bugs, and outages. This doesn't seem to qualify for that, so I'll remove the Soon label.

@dmitshur dmitshur removed the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Feb 25, 2020
@jeremyfaller
Copy link
Contributor

Sorry 'bout that. Probably got lost in the runup to 1.14 freeze. I'll take a look.

@dmitshur
Copy link
Contributor

No problem, and thank you Jeremy. I just wanted to update our list of Soon issues.

@cherrymui
Copy link
Member

My guess is that this is due to alignment padding between segments. It seems the failures are all on architectures with large alignment (usually 0x10000 i.e. 64K). Worst case the alignment padding can increase the binary size by 64K, which can shadow the 50K difference we're looking for.

If the test is checking if the table is dropped by the linker, maybe use the nm command to look for particular symbols?

@cherrymui
Copy link
Member

Or it can add the size of sections without the paddings. But then it needs to be OS dependent: will need codepaths for ELF, Mach-O, xcoff, etc..

@cherrymui
Copy link
Member

Or the test can use linker's -R flag to reduce the alignment. This might cause problems at run time, but we don't run the resulted binaries.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/221104 mentions this issue: unicode/norm: look for symbols in TestLinking

@golang golang locked and limited conversation to collaborators Mar 6, 2021
@rsc rsc unassigned mpvl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rsc @dmitshur @jeremyfaller @bcmills @mpvl @gopherbot @cherrymui