Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: race in TestConfigDefaultEnv/GOPATH #34196

Closed
stamblerre opened this issue Sep 9, 2019 · 1 comment
Closed

x/tools/go/packages: race in TestConfigDefaultEnv/GOPATH #34196

stamblerre opened this issue Sep 9, 2019 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

Noticed this on builders.
Logs: https://storage.googleapis.com/go-build-log/51c8d969/linux-amd64-race_830cf157.log.

================== WARNING: DATA RACE Read at 0x00c00039bc50 by goroutine 57: runtime.slicecopy() /workdir/go/src/runtime/slice.go:197 +0x0 golang.org/x/tools/go/packages.invokeGo() /workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:857 +0x1e0 golang.org/x/tools/go/packages.determineRootDirsGOPATH() /workdir/gopath/src/golang.org/x/tools/go/packages/golist_overlay.go:224 +0xc8 golang.org/x/tools/go/packages.determineRootDirs() /workdir/gopath/src/golang.org/x/tools/go/packages/golist_overlay.go:205 +0x36e golang.org/x/tools/go/packages.goListDriver.func2() /workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:116 +0x3c

Previous write at 0x00c00039bc50 by goroutine 58:
golang.org/x/tools/go/packages_test.testConfigDefaultEnv.func1()
/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:1891 +0x287
testing.tRunner()
/workdir/go/src/testing/testing.go:909 +0x199

Goroutine 57 (running) created at:
golang.org/x/tools/go/packages.goListDriver()
/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:115 +0x22b
golang.org/x/tools/go/packages.defaultDriver()
/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:226 +0x79
golang.org/x/tools/go/packages.Load()
/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:211 +0x93
golang.org/x/tools/go/packages_test.testConfigDefaultEnv.func1()
/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:1892 +0x3e4
testing.tRunner()
/workdir/go/src/testing/testing.go:909 +0x199

Goroutine 58 (running) created at:
testing.(*T).Run()
/workdir/go/src/testing/testing.go:960 +0x651
golang.org/x/tools/go/packages_test.testConfigDefaultEnv()
/workdir/gopath/src/golang.org/x/tools/go/packages/packages_test.go:1887 +0x7ed
golang.org/x/tools/go/packages/packagestest.TestAll.func1()
/workdir/gopath/src/golang.org/x/tools/go/packages/packagestest/export.go:102 +0x91
testing.tRunner()
/workdir/go/src/testing/testing.go:909 +0x199

--- FAIL: TestConfigDefaultEnv (0.06s)
--- FAIL: TestConfigDefaultEnv/GOPATH (0.02s)
--- FAIL: TestConfigDefaultEnv/GOPATH/driver_set (0.01s)
testing.go:853: race detected during execution of test
testing.go:853: race detected during execution of test
testing.go:853: race detected during execution of test
FAIL
FAIL golang.org/x/tools/go/packages 54.823s

/cc @matloob
@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2019
@stamblerre stamblerre added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 9, 2019
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 16, 2019
@matloob
Copy link
Contributor

matloob commented Oct 29, 2019

I believe this was fixed by https://go-review.googlesource.com/c/tools/+/203897.

@matloob matloob closed this as completed Oct 29, 2019
@golang golang locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@toothrot @stamblerre @gopherbot @matloob