Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy.golang.org: Add FAQ item on https://proxy.golang.org/ about use of private modules #34153

Closed
bvwells opened this issue Sep 6, 2019 · 3 comments

Comments

@bvwells
Copy link

bvwells commented Sep 6, 2019

What version of Go are you using (go version)?

go version go1.13 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env $ go env
set GOARCH=amd64
set GOOS=windows

What did you do?

I had some concerns about the use of https://proxy.golang.org/ in Go 1.13 as to whether private go modules appear in the index database https://index.golang.org if the GOPRIVATE environment variable is not set.

I read through the documentation and couldn't really find the documented behaviour for this. Apologies if I missed it. After a discussion on the modules slack channel it was suggested to post an issue to suggest the addition of an item in the FAQ section of https://proxy.golang.org/ or https://index.golang.org to describe the behaviour of the index database with private modules.

What did you expect to see?

I expected to see some documentation on the https://proxy.golang.org/ or https://index.golang.org about the behaviour of the proxy and index database for private modules. Perhaps in the FAQ section.

What did you see instead?

It was good to see that the privacy information for the new proxy was at top of the documentation. However, I couldn't find any information on the behaviour of the index database with private modules.

@bvwells bvwells changed the title proxy.golang.org: Add FAQ item on https://proxy.golang.org/ about use private modules proxy.golang.org: Add FAQ item on https://proxy.golang.org/ about use of private modules Sep 6, 2019
@heschi heschi added the modules label Sep 6, 2019
@heschi heschi self-assigned this Sep 6, 2019
@heschi
Copy link
Contributor

heschi commented Sep 6, 2019

cc @katiehockman, @hyangah

@heschi
Copy link
Contributor

heschi commented Sep 9, 2019

The new FAQ question is now published, subject to a brief HTTP cache delay. We also updated the wording in a few places to mention GOPRIVATE. If you have any significant issues with the wording, let us know.

@heschi heschi closed this as completed Sep 9, 2019
@bvwells
Copy link
Author

bvwells commented Sep 10, 2019

Thanks @heschik for your help and the speedy update to the FAQs!

@golang golang locked and limited conversation to collaborators Sep 9, 2020
@rsc rsc unassigned heschi Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants