New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/types: interfaces must be marked complete before they can be compared #34151
Comments
This bisects to a80c5f0 by @griesemer.
This is breaking thousands of tests inside Google, but I can't revert it because it's part of the language change which supposedly is already in use, so marking P1 (Soon). /cc @mdempsky @golang/osp-team |
on it |
Hm, tangentially, I suppose cmd/compile should complain about overlapping interfaces when -lang=go1.13 or earlier is specified? |
@griesemer To clarify, it's not causing visible internal breakage (we don't make people run tip), but it's blocking us from testing tip against Google tests as we do every week, because they all break around protobufs. Not an emergency. |
If it's just protobufs that are breaking, I think it's a one-line fix to get it working for now. Just delete this line: |
Or move that line to a _test.go file, to make it a protobuf test failure rather than a protobuf build failure. |
Change https://golang.org/cl/195837 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
With tip.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
No error, since
T
andp.T
have identical underlying types.What did you see instead?
A vet error.
The text was updated successfully, but these errors were encountered: