Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa/interp: tests broken at Go CL 191198 #34089

Closed
bcmills opened this issue Sep 4, 2019 · 5 comments
Closed

x/tools/go/ssa/interp: tests broken at Go CL 191198 #34089

bcmills opened this issue Sep 4, 2019 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Sep 4, 2019

CL 191198 changed the error message written by the compiler for unhashable types.

Apparently the tests for x/tools/go/ssa/interp were relying on the exact error message, because they are now failing in the builders:
https://build.golang.org/log/b4fad15a40867a4f25fdf2fdacbe3bcc13408bad

CC @ianthehat @randall77 @martisch
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Sep 4, 2019
@gopherbot gopherbot added this to the Unreleased milestone Sep 4, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/193377 mentions this issue: go/ssa/interp: skip recover2 testcase

gopherbot pushed a commit to golang/tools that referenced this issue Sep 4, 2019
@matloob
go/ssa/interp: skip recover2 testcase
958971f 
The test case (taken from the go distribution itself) seems to be broken
when run against tip. Disable it when run against tip.

Updates golang/go#34089

Change-Id: I47d2e12ca39bc060fe0a0c967e95b900bdd0d725
Reviewed-on: https://go-review.googlesource.com/c/tools/+/193377
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@stamblerre stamblerre added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 9, 2019
@bcmills bcmills added Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) and removed Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Sep 10, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/220957 mentions this issue: go/ssa: disable recover2 testcase

gopherbot pushed a commit to golang/tools that referenced this issue Feb 25, 2020
@matloob
go/ssa: disable recover2 testcase
12e620e 
We still haven't figured out what's going on, but this is a low
priority because the SSA interpreter isn't used by anyone.
The primary concern is that this might be covering a legitimate
underlying SSA bug.

Updates golang/go#34089

Change-Id: I2886845b4f4b011104de945d04d6b8c4c436cbe9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/220957
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@matloob matloob removed the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Feb 25, 2020
@matloob
Copy link
Contributor

matloob commented Feb 25, 2020

Removing Soon because ssa/interp is not heavily used, and the test is no longer a time bomb.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/220959 mentions this issue: go/ssa/interp: remove unused import

gopherbot pushed a commit to golang/tools that referenced this issue Feb 25, 2020
go/ssa/interp: remove unused import
ee3f114 
Updates golang/go#34089

Change-Id: Ic7cc45803a31394241c7fa33092ec566dbf296ca
Reviewed-on: https://go-review.googlesource.com/c/tools/+/220959
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bcmills
Copy link
Contributor Author

bcmills commented May 16, 2023

Closing as obsolete; this test has been passing on most builders.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
@golang golang locked and limited conversation to collaborators May 15, 2024
gopherbot pushed a commit to golang/tools that referenced this issue Oct 25, 2024
@adonovan
go/ssa/interp: fix failing recover2.go test
Loading
Loading status checks…
7d196fc 
The "unhashable" panic message had changed in go1.14.

Fixes golang/go#34089

Change-Id: I6ba97d33fefee9e217b65904db2b07c2091d80be
Reviewed-on: https://go-review.googlesource.com/c/tools/+/621676
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Tim King <taking@google.com>
Commit-Queue: Alan Donovan <adonovan@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bcmills @stamblerre @gopherbot @matloob