Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gopls: references returns the declaration position twice #34087

Closed
myitcv opened this issue Sep 4, 2019 · 1 comment
Closed

x/tools/cmd/gopls: references returns the declaration position twice #34087

myitcv opened this issue Sep 4, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@myitcv
Copy link
Member

myitcv commented Sep 4, 2019

What version of Go are you using (go version)?

$ go version
go version devel +9da7abd2eb Tue Sep 3 18:35:32 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190904201204-7dc6b39912d7
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.1.4-0.20190904201204-7dc6b39912d7

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build652194260=/tmp/go-build -gno-record-gcc-switches"

What did you do?

package main

import "fmt"

var v int

func main() {
	v = 5
	fmt.Println("hello world!", v)
}

Then find references for v.

What did you expect to see?

Three results:

{
    URI:   "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Range: protocol.Range{
        Start: protocol.Position{Line:4, Character:4},
        End:   protocol.Position{Line:4, Character:5},
    },
},
{
    URI:   "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Range: protocol.Range{
        Start: protocol.Position{Line:8, Character:29},
        End:   protocol.Position{Line:8, Character:30},
    },
},
{
    URI:   "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Range: protocol.Range{
        Start: protocol.Position{Line:7, Character:1},
        End:   protocol.Position{Line:7, Character:2},
    },
},

What did you see instead?

Four results: the declaration is returned twice:

{
    URI:   "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Range: protocol.Range{
        Start: protocol.Position{Line:4, Character:4},
        End:   protocol.Position{Line:4, Character:5},
    },
},
{
    URI:   "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Range: protocol.Range{
        Start: protocol.Position{Line:4, Character:4},
        End:   protocol.Position{Line:4, Character:5},
    },
},
{
    URI:   "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Range: protocol.Range{
        Start: protocol.Position{Line:8, Character:29},
        End:   protocol.Position{Line:8, Character:30},
    },
},
{
    URI:   "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go",
    Range: protocol.Range{
        Start: protocol.Position{Line:7, Character:1},
        End:   protocol.Position{Line:7, Character:2},
    },
},

cc @stamblerre @ianthehat
@myitcv myitcv added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. labels Sep 4, 2019
@gopherbot gopherbot added this to the Unreleased milestone Sep 4, 2019
@gopherbot
Copy link

Change https://golang.org/cl/193379 mentions this issue: internal/lsp: fix declarations in references

@golang golang locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@myitcv @gopherbot