Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: 'go test' adds test.timeout flag after positional arguments [1.13 backport] #34083

Closed
gopherbot opened this issue Sep 4, 2019 · 5 comments
Closed

cmd/go: 'go test' adds test.timeout flag after positional arguments [1.13 backport] #34083

gopherbot opened this issue Sep 4, 2019 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@bcmills requested issue #34072 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13: this is a regression and the fix is trivial.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 4, 2019
@gopherbot gopherbot mentioned this issue Sep 4, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 4, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/193269 mentions this issue: [release-branch.go1.13] cmd/go/internal/test: prepend -test.timeout rather than appending

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Sep 5, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 5, 2019
@gopherbot
Copy link
Author

Closed by merging 6bbfea9 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Sep 5, 2019
[release-branch.go1.13] cmd/go/internal/test: prepend -test.timeout r…
6bbfea9 
…ather than appending

Tests may accept positional arguments, in which case the -test.timeout
flag must be passed before those arguments.

Updates #34072
Fixes #34083

Change-Id: I5b92d7c0edc4f9e1efb63b0733937b76236c0eff
Reviewed-on: https://go-review.googlesource.com/c/go/+/193297
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit d21953d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/193269
@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@lanfengye2008
Copy link

Can 1.13.2 be released as soon as possible?

@bcmills
Copy link
Contributor

bcmills commented Sep 27, 2019

@lanfengye2008, I believe that 1.13.2 is planned for early October.

In the meantime, you have several options:

@lanfengye2008
Copy link

@lanfengye2008, I believe that 1.13.2 is planned for early October.

In the meantime, you have several options:

Thank you!

@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @katiehockman @lanfengye2008