Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: errors: wrong unwrap example [1.13 backport] #34082

Closed
gopherbot opened this issue Sep 4, 2019 · 3 comments
Closed

doc: errors: wrong unwrap example [1.13 backport] #34082

gopherbot opened this issue Sep 4, 2019 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@jba requested issue #34061 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport 1.13
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 4, 2019
@gopherbot gopherbot mentioned this issue Sep 4, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 4, 2019
@katiehockman katiehockman added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 4, 2019
@katiehockman
Copy link
Contributor

Approved as this is a documentation fix.

@jba go ahead and continue the process here and add me as a reviewer: https://github.com/golang/go/wiki/MinorReleases#making-cherry-pick-cls

@gopherbot
Copy link
Author

Change https://golang.org/cl/193263 mentions this issue: [release-branch.go1.13] errors: fix wrong code in package doc

@gopherbot
Copy link
Author

Closed by merging b7ff8ff to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Sep 4, 2019
@jba @katiehockman
[release-branch.go1.13] errors: fix wrong code in package doc
b7ff8ff 
You can't call Unwrap on the return value of fmt.Errorf, but
you can pass the result to errors.Unwrap.

Also, move the description of the Unwrap function up so the
example makes sense.

Fixes #34082.

Change-Id: Ica07c44665c5e65deea4aa6a146fc543a5a0a99d
Reviewed-on: https://go-review.googlesource.com/c/go/+/193298
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Katie Hockman <katie@golang.org>
(cherry picked from commit d9a3d90)
Reviewed-on: https://go-review.googlesource.com/c/go/+/193263
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @katiehockman