Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get panics in GOPATH mode on custom import path with an insecure redirect [1.13 backport] #34081

Closed
gopherbot opened this issue Sep 4, 2019 · 3 comments
Closed

cmd/go: go get panics in GOPATH mode on custom import path with an insecure redirect [1.13 backport] #34081

gopherbot opened this issue Sep 4, 2019 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@bcmills requested issue #34049 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13. This panic makes insecure redirects much harder to diagnose, and the fix is trivial.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 4, 2019
@gopherbot gopherbot mentioned this issue Sep 4, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 4, 2019
@bcmills bcmills self-assigned this Sep 4, 2019
@bcmills bcmills changed the title cmd/go: go get fails in GOPATH mode on custom import path with a redirect [1.13 backport] cmd/go: go get panics in GOPATH mode on custom import path with an insecure redirect [1.13 backport] Sep 4, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/193264 mentions this issue: [release-branch.go1.13] cmd/go/internal/get: avoid panic in metaImportsForPrefix if web.Get fails

@dmitshur
Copy link
Contributor

dmitshur commented Sep 4, 2019

Approving. The provided rationale meets the backporting criteria.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 4, 2019
@gopherbot
Copy link
Author

Closed by merging 052d7c8 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Sep 11, 2019
[release-branch.go1.13] cmd/go/internal/get: avoid panic in metaImpor…
052d7c8 
…tsForPrefix if web.Get fails

Updates #29591
Updates #34049
Fixes #34081

Change-Id: I817b83ee2d0ca6d01ec64998f14bc4f32e365d66
Reviewed-on: https://go-review.googlesource.com/c/go/+/193259
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 1eab1aa6ba6c3f4d6f084751bca9a065707c3085)
Reviewed-on: https://go-review.googlesource.com/c/go/+/193264
Reviewed-by: Jay Conrod <jayconrod@google.com>
@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @katiehockman