-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add builder for netbsd/arm64 #34036
Comments
Change https://golang.org/cl/192997 mentions this issue: |
Those configurations currently lack builders, and it is not clear to me what state their tests are in. The Go porting policy¹ requires builders for all active ports, so let's not claim support until that requirement is met. ¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port Updates #30824 Updates #31656 Updates #34035 Updates #34036 Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b Reviewed-on: https://go-review.googlesource.com/c/go/+/192997 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change https://golang.org/cl/192998 mentions this issue: |
…port on NetBSD and OpenBSD Those configurations currently lack builders, and it is not clear to me what state their tests are in. The Go porting policy¹ requires builders for all active ports, so let's not claim support until that requirement is met. ¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port Updates #30824 Updates #31656 Updates #34035 Updates #34036 Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b Reviewed-on: https://go-review.googlesource.com/c/go/+/192997 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> (cherry picked from commit 9f5127b) Reviewed-on: https://go-review.googlesource.com/c/go/+/192998 Run-TryBot: Bryan C. Mills <bcmills@google.com>
Sorry that this was not clearer. We do not, as a matter of fact, have a netbsd/arm64 builder. The netbsd-arm-bsiegert is arm, as the name says. Right now, binaries compiled on netbsd/arm64 die when they receive a signal, so we cannot sensibly run the go tool on it. Rest assured that I'll take care of a builder when we are at that point. For now, removing arm64 from the release notes SGTM. |
Thanks for the confirmation! |
Those configurations currently lack builders, and it is not clear to me what state their tests are in. The Go porting policy¹ requires builders for all active ports, so let's not claim support until that requirement is met. ¹https://golang.org/wiki/PortingPolicy#requirements-for-a-new-port Updates golang#30824 Updates golang#31656 Updates golang#34035 Updates golang#34036 Change-Id: I6496de9d92fb8546048abf139cf10546a47e314b Reviewed-on: https://go-review.googlesource.com/c/go/+/192997 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
While Go will build for these platforms, neither currently has a builder and netbsd/arm64 is apparently broken. It looks like the Go 1.13 release notes were updated to remove the announcement of these ports. Support for netbsd/arm64 is tracked in golang/go#34036 and support for openbsd/arm64 is tracked in golang/go#34035. Signed-off-by: Jacob Howard <jacob@havoc.io>
@bsiegert I saw your recent message on golang-dev. Let's use this as the tracking issue for the next steps. I can send you a builder key soon (on Monday). /cc @cagedmantis Issue #36841 may be relevant here. Please let us know if you think it would be viable to have a non-reverse builder for NetBSD ARM64. I think we can proceed with a reverse builder for now, but if a non-reserve builder becomes possible/easy in the future, let's evaluate that option too. |
I've provided a builder key to @bsiegert. Benny, please update this issue and/or ping me when you're ready to take the next steps here. |
@cagedmantis I am excited to hear about the non-reverse arm64 builder! There does not need to be any waiting involved; we can have both builders for the time being, and I'll happily decommission the reverse builder. @dmitshur provided a key, and I have the builder running right now. I will send a CL to add it to the coordinator. |
Change https://golang.org/cl/249137 mentions this issue: |
Update golang/go#34036 Change-Id: Ic92093e764fa163d97a2f125a4534581adf217da Reviewed-on: https://go-review.googlesource.com/c/build/+/249137 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
@cagedmantis How is the non-reverse builder coming along? Anything I can do to help? |
I don't believe there are active plans to pursue a non-reverse netbsd/arm64 builder now, and a newer reverse builder for LUCI was added: https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-netbsd-arm64. Closing this in favor of the newer issue #63614. |
The Go 1.13 release notes currently claim that “Go now supports NetBSD on arm64.”
We have a
host-netbsd-arm-bsiegert
builder, but it isn't clear to me whether that is regular ARM or ARM64.By last report (#30824 (comment)), the
netbsd/arm64
build may be broken.We should either get a
netbsd/arm64
builder up and running and verify that it is passing, or remove the claim of support from the release notes.CC @bsiegert @bradfitz @ianlancetaylor @andybons @toothrot @dmitshur
The text was updated successfully, but these errors were encountered: