Thrift has officially switched to to github with v0.12.0, which was released last year. We've supported cloning from git.apache.org for a while for backwards compatibility, but that's gone now. You don't need a replace directive, just import github.com/apache/thrift.

The problem still persist if other required modules still require git.apache.org/thrift.git. In that case the error is very persistent and I had some difficulties to fix it. Even with the replace statement, I first couldn’t get rid of it. It was even difficult to find out which modules still require the old URL, because go mod graph only complaints about problems with git.apache.org as well as go mod tidy and even go clean —modcache.

I can’t tell anymore but I believe deleting the modules cache manually finally did the trick (while keeping the replace statement).

thanks, go mod graph tells which modules still requires the old module.

I'm not able to reproduce a hang. I do see a long delay during the direct-mode fetch, but it eventually resolves to a useful error message.

@ukai, is there something in your global Git config that would prevent git commands from timing out as usual?

example.com$ gotip mod init example.com
go: creating new go.mod: module example.com

example.com$ cat | gofmt > main.go
package main

import _ "git.apache.org/thrift.git"

func main() {}

example.com$ gotip list -m all
example.com

example.com$ gotip mod tidy
go: finding git.apache.org/thrift.git v0.12.0
go: downloading git.apache.org/thrift.git v0.12.0
go: extracting git.apache.org/thrift.git v0.12.0
example.com imports
        git.apache.org/thrift.git: module git.apache.org/thrift.git@latest (v0.12.0) found, but does not contain package git.apache.org/thrift.git

example.com$ gotip mod init example.com
go: creating new go.mod: module example.com

example.com$ cat | gofmt > main.go
package main

import _ "git.apache.org/thrift.git"

func main() {}

example.com$ GOPROXY=direct gotip mod tidy
example.com imports
        git.apache.org/thrift.git: git ls-remote -q origin in /tmp/tmp.QfnCyUFnCW/_gopath/pkg/mod/cache/vcs/f6f367fb9d5656665ab3c2c1c3b2a44c2ffc79f6b70612f5864d7ceedcc7b9ea: exit status 128:
        fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Connection timed out

Change https://golang.org/cl/193039 mentions this issue: all: upgrade dependencies on google.golang.org/api and go.opencensus.io

Change https://golang.org/cl/193097 mentions this issue: blog: add replace directives for git.apache.org

Change https://golang.org/cl/193098 mentions this issue: all: upgrade dependency on x/website

As far as I can tell there is nothing more to be done here. As @ukai notes, you can use a replace directive as a temporary workaround, and as @dcelasun notes, it is usually possible to remove the bad dependency by upgrading past whatever depends on it.

You can figure out “whatever depends on it” using go mod graph | grep git.apache.org.

For the replace directive, I would recommend replacing the specific commit with the same specific commit under github.com, since that will be least disruptive to the rest of the module graph. For example:

replace git.apache.org/thrift.git v0.0.0-20181218151757-9b75e4fe745a => github.com/apache/thrift v0.0.0-20181218151757-9b75e4fe745a

Also, I plan on including a go.mod file with the upcoming v0.13.0 of thrift, so pinning a specific commit shouldn't be necessary after that.

@dcelasun, adding a go.mod file in the github.com/apache/thrift repo seems fine, but won't really help with this issue in particular.

(github.com/apache/thrift/lib/go/thrift already resolves just fine at v0.12.0 — it's the change in import path that broke things, not the lack of go.mod file.)

@bcmills sorry my comment was a bit tangential, just wanted to mention it after seeing that replace line.