Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: support label completions #33987

Closed
muirdm opened this issue Aug 30, 2019 · 2 comments
Closed

x/tools/gopls: support label completions #33987

muirdm opened this issue Aug 30, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@muirdm
Copy link

muirdm commented Aug 30, 2019

Gopls should give label completions for continue, break and goto statements. For example:

Loop:
for i := range foo {
  switch i {
  case 0:
    break <>
  }
}

We should offer the Loop completion when completing at <>.

Labels do not behave like normal identifiers for scoping/shadowing, so some special handling will be required.
@gopherbot gopherbot added this to the Unreleased milestone Aug 30, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Aug 30, 2019
@stamblerre stamblerre added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 9, 2019
@gopherbot
Copy link

Change https://golang.org/cl/197417 mentions this issue: internal/lsp: add label completion candidates

@golang golang locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @muirdm