-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/cover: cannot run in directory with no .go files [1.13 backport] #33984
Comments
Change https://golang.org/cl/192722 mentions this issue: |
@rhysh @bcmills would you categorized this as a serious problem with no workaround? Under our policy at https://github.com/golang/go/wiki/MinorReleases, only fixes for security issues, serious problems with no workaround, and documentation fixes will be backported. |
It's a regression from 1.12. There is a workaround (which is to avoid running |
@andybons commented in the change, but to re-iterate here: let's wait to approve and merge this until 1.13 is out. This can be added to a point release since it isn't a major issue, even if the fix is small |
OK. 1.13 is out. Will let whomever is on rotation make the final call. |
Closed by merging 7d1c61c to release-branch.go1.13. |
Only call "go list" when explicitly listing packages. An empty coverage profile references no packages, and would otherwise lead to "go list" implicitly looking at the package in "." (which might not exist). Fixes #33984 Change-Id: I02d4e374405d86f03d105fe14648aa03b4d2284c Reviewed-on: https://go-review.googlesource.com/c/go/+/192340 Reviewed-by: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit 9d480ed) Reviewed-on: https://go-review.googlesource.com/c/go/+/192722
@rhysh requested issue #33855 to be considered for backport to the next 1.13 minor release.
The text was updated successfully, but these errors were encountered: