Skip to content

x/tools/go/packages: TestOverlayModFileChanges broken at head #33956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Aug 29, 2019 · 4 comments
Closed

x/tools/go/packages: TestOverlayModFileChanges broken at head #33956

bcmills opened this issue Aug 29, 2019 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2019

I'm not sure why this isn't showing up in the builders, but TestOverlayModFileChanges is failing consistently for me on everything from go1.12.9 to gotip:

~/src/golang.org/x/tools$ git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.

~/src/golang.org/x/tools$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

~/src/golang.org/x/tools$ go1.13rc2 test ./go/packages
--- FAIL: TestOverlayModFileChanges (0.43s)
    packages_test.go:1119: expected module mod2

        go 1.11
        , got module mod2

        go 1.11

        require golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7 // indirect
FAIL
FAIL    golang.org/x/tools/go/packages  10.118s
FAIL

~/src/golang.org/x/tools$

CC @matloob @ianthehat
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Aug 29, 2019
@bcmills bcmills added this to the Go1.13 milestone Aug 29, 2019
@bcmills bcmills mentioned this issue Aug 29, 2019
Open
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/192397 mentions this issue: go/packages: set GOPACKAGESDRIVER=off for all the tests

@matloob
Copy link
Contributor

matloob commented Aug 29, 2019

For context, this was probably happening because some tests weren't setting GOPACKAGESDRIVER=off, which allowed a user's environment to affect the tests.

@matloob
Copy link
Contributor

matloob commented Aug 29, 2019

(Could you reopen if the change doesn't fix the issue?)

@bcmills
Copy link
Contributor Author

bcmills commented Aug 29, 2019

Yep, that did the trick.

@golang golang locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
4 participants
@bcmills @stamblerre @gopherbot @matloob