Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/perf/analysis/appengine: failing in release-branch.go1.12 builders #33952

Closed
bcmills opened this issue Aug 29, 2019 · 1 comment
Closed

x/perf/analysis/appengine: failing in release-branch.go1.12 builders #33952

bcmills opened this issue Aug 29, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2019

As of CL 191378, the x/perf build now requires module mode in order to build the binaries in analysis/appengine.

The problem seems to be the dependency on google.golang.org/appengine, which used to be notched out by the +build appengine constraint but no longer is.

That works fine on builders in module mode, because they can fetch the module — but it causes the builds to fail in GOPATH-mode builders.

CC @andybons @katiehockman @toothrot @dmitshur
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 29, 2019
@gopherbot gopherbot added this to the Unreleased milestone Aug 29, 2019
@bcmills bcmills changed the title x/perf/analysis/appenginer: failing in release-branch.go1.12 builders x/perf/analysis/appengine: failing in release-branch.go1.12 builders Aug 29, 2019
@bcmills bcmills mentioned this issue Aug 29, 2019
Open
@gopherbot
Copy link

Change https://golang.org/cl/192333 mentions this issue: dashboard: set GO111MODULE=on for x/perf

codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@codebien
dashboard: set GO111MODULE=on for x/perf
19f247d 
CL 191378 removed some +build appengine tags from
./analysis/appengine, so those packages now require
GO111MODULE=on in order to resolve the dependency
on google.golang.org/appengine.

Fixes golang/go#33952

Change-Id: I20c9ba3f42d488265726fda9b1c790e48a1433b3
Reviewed-on: https://go-review.googlesource.com/c/build/+/192333
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot