Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools: missing Skips for tests that invoke the 'go' command #33950

Closed
bcmills opened this issue Aug 29, 2019 · 2 comments
Closed

x/tools: missing Skips for tests that invoke the 'go' command #33950

bcmills opened this issue Aug 29, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2019

The illumos-amd64-joyent builder currently lacks a go command in its path.
That exposes a large number of tests within x/tools that assume that the go command is present instead of calling t.Skip:
https://build.golang.org/log/eef252c96a74b9a0046d5fa407752a33550c3f8a
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Aug 29, 2019
@gopherbot gopherbot added this to the Unreleased milestone Aug 29, 2019
@bcmills bcmills mentioned this issue Aug 29, 2019
Open
@bcmills bcmills self-assigned this Aug 29, 2019
@gopherbot

This comment has been minimized.

Sign in to view
@gopherbot
Copy link

Change https://golang.org/cl/192400 mentions this issue: all: skip tests if required tools are not found

jocgir pushed a commit to jocgir/gotools that referenced this issue Apr 29, 2020
all: skip tests if required tools are not found
d59527d 
Fixes golang/go#33950

Change-Id: Iefcb757e773bc052793611c099c25a457fd7e243
Reviewed-on: https://go-review.googlesource.com/c/tools/+/192400
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
@golang golang locked and limited conversation to collaborators Aug 29, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot